-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feedback): Add UF screenshot capability #9867
Merged
Merged
Changes from 10 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f0a4601
add screenshot to docs
c298lee d5d7242
Update docs/platforms/javascript/common/user-feedback/configuration/i…
c298lee 328abb7
Update docs/platforms/javascript/common/user-feedback/index.mdx
c298lee 0a1d08f
Update docs/platforms/javascript/common/user-feedback/index.mdx
jas-kas 3f9d18f
Update docs/platforms/javascript/common/user-feedback/index.mdx
c298lee 44cef3f
Update docs/platforms/javascript/common/user-feedback/configuration/i…
c298lee 36c88da
Update docs/platforms/javascript/common/user-feedback/index.mdx
c298lee a2743d9
Update docs/platforms/javascript/common/user-feedback/index.mdx
c298lee 0490077
Update index.mdx
c298lee 422f382
Update docs/platforms/javascript/common/user-feedback/index.mdx
c298lee 7cd0151
Update index.mdx
c298lee 3352863
Update index.mdx
c298lee 32f3c6d
Update docs/platforms/javascript/common/user-feedback/configuration/i…
c298lee 09f74ce
Update docs/platforms/javascript/common/user-feedback/index.mdx
c298lee 050cbbc
screenshots
c298lee f8f205e
showscreenshot renamed + pr comment
c298lee 74f8656
Update index.mdx
c298lee f82eda9
Update index.mdx
c298lee 8bb9d57
Update index.mdx
c298lee 093d4b3
update screenshots
c298lee b243a95
hopefully last modification
c298lee File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we mention here (and on the config page above too) the min. version for on-prem users to have that enables screenshot support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, is on-prem the same as ST?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've got:
S4S is an example of ST where we can deploy the sentry codebase and not affect sentry.io. ST and On-Prem have very similar configs, while the SaaS codebase is special because it has the extra billing layer added on top (all the features are the same everywhere though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated! Feel free to make a suggestion if the wording is iffy