Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fill_extra_context option to the symfony documentation #9824

Merged
merged 3 commits into from May 9, 2024

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Apr 26, 2024

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Add fill_extra_context option to the symfony documentation. https://github.com/getsentry/sentry-php/blob/master/src/Monolog/Handler.php

See also comment from @nuryagdym getsentry/sentry-php#870 (comment)

Thx @CViniciusSDias for the hint.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Extra resources

Copy link

vercel bot commented Apr 26, 2024

@alexander-schranz is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 6:00pm

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cleptric Can you also take a look at this?

docs/platforms/php/guides/symfony/index.mdx Outdated Show resolved Hide resolved
@vivianyentran
Copy link
Contributor

@cleptric Can you take a look?

@vivianyentran vivianyentran merged commit 584beb9 into getsentry:master May 9, 2024
6 checks passed
@alexander-schranz alexander-schranz deleted the patch-1 branch May 9, 2024 00:40
antonpirker pushed a commit that referenced this pull request May 14, 2024
* Add fill_extra_context option to the symfony documentation

* Add also the context data to test example

* Update docs/platforms/php/guides/symfony/index.mdx

Co-authored-by: vivianyentran <[email protected]>

---------

Co-authored-by: vivianyentran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants