Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add span level measurements #1855 #2214

Merged

Conversation

martinhaintz
Copy link
Collaborator

@martinhaintz martinhaintz commented Aug 5, 2024

📜 Description

Add support for span level measurements #1855

💡 Motivation and Context

Closes #1855

💚 How did you test it?

Unittests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.28%. Comparing base (384a55c) to head (30c9e3d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2214      +/-   ##
==========================================
+ Coverage   88.22%   88.28%   +0.05%     
==========================================
  Files         230      230              
  Lines        7899     7905       +6     
==========================================
+ Hits         6969     6979      +10     
+ Misses        930      926       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
dart/lib/src/noop_sentry_span.dart Outdated Show resolved Hide resolved
@buenaflor buenaflor marked this pull request as ready for review August 5, 2024 14:09
CHANGELOG.md Show resolved Hide resolved
dart/lib/src/sentry_tracer.dart Show resolved Hide resolved
Co-authored-by: Giancarlo Buenaflor <[email protected]>
@martinhaintz martinhaintz marked this pull request as draft August 6, 2024 09:13
@buenaflor buenaflor marked this pull request as ready for review August 6, 2024 10:59
@buenaflor buenaflor merged commit 7ec9238 into getsentry:main Aug 6, 2024
127 checks passed
@martinhaintz martinhaintz deleted the feat/support-span-level-measurements branch August 6, 2024 12:14
martinhaintz added a commit that referenced this pull request Aug 7, 2024
* main:
  Add proxy support (#2192)
  Deserialize and serialize unknown fields (#2153)
  feat: add `ignoreTransactions` and ignoreErrors` #1391 (#2207)
  feat: add span level measurements #1855 (#2214)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support span level measurements
3 participants