Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breadcrumb for GestureDetector onTap #2067

Closed
wants to merge 2 commits into from
Closed

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented May 21, 2024

馃摐 Description

馃挕 Motivation and Context

Relates to #2012

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

馃敭 Next steps

Copy link
Contributor

github-actions bot commented May 21, 2024

Fails
馃毇 Please consider adding a changelog entry for the next release.
Messages
馃摉 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add breadcrumb for `GestureDetector` onTap ([#2067](https://github.com/getsentry/sentry-dart/pull/2067))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 馃毇 dangerJS against 1dceadc

Copy link
Contributor

github-actions bot commented May 21, 2024

iOS Performance metrics 馃殌

Plain With Sentry Diff
Startup time 1230.90 ms 1246.37 ms 15.47 ms
Size 8.32 MiB 9.52 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
50bdfad 1253.14 ms 1274.54 ms 21.40 ms
1131914 1277.20 ms 1300.20 ms 23.00 ms
8a10ab7 1226.49 ms 1250.52 ms 24.03 ms
afa6e2a 1251.04 ms 1266.65 ms 15.61 ms
1c6eb5b 1277.85 ms 1285.71 ms 7.86 ms
8932ece 1234.31 ms 1238.90 ms 4.59 ms
8ced2dc 1258.35 ms 1272.98 ms 14.62 ms
e5b744f 1250.82 ms 1284.46 ms 33.64 ms
42f6e7e 1232.52 ms 1247.86 ms 15.34 ms
f922f8f 1249.53 ms 1266.51 ms 16.98 ms

App size

Revision Plain With Sentry Diff
50bdfad 8.32 MiB 9.43 MiB 1.10 MiB
1131914 8.16 MiB 9.17 MiB 1.01 MiB
8a10ab7 8.28 MiB 9.34 MiB 1.06 MiB
afa6e2a 8.28 MiB 9.33 MiB 1.05 MiB
1c6eb5b 8.15 MiB 9.12 MiB 986.27 KiB
8932ece 8.29 MiB 9.36 MiB 1.07 MiB
8ced2dc 8.10 MiB 9.16 MiB 1.07 MiB
e5b744f 8.09 MiB 9.07 MiB 1001.19 KiB
42f6e7e 8.28 MiB 9.33 MiB 1.05 MiB
f922f8f 8.15 MiB 9.13 MiB 1003.20 KiB

@denrase
Copy link
Collaborator Author

denrase commented May 21, 2024

@marandaneto Hello there! :) Do you know why we specifically tested that GestureRecognizer does not trigger a crumb when containing a button?

'Add crumb for ElevatedButton within a GestureDetector with label',

Copy link
Contributor

Android Performance metrics 馃殌

Plain With Sentry Diff
Startup time 348.21 ms 412.83 ms 64.62 ms
Size 6.33 MiB 7.30 MiB 992.52 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
636cb61 366.59 ms 448.14 ms 81.55 ms
21845e2 345.08 ms 382.82 ms 37.74 ms
2331d89 352.45 ms 417.34 ms 64.89 ms
f4cc744 349.53 ms 394.68 ms 45.15 ms
1596141 300.92 ms 368.94 ms 68.02 ms
3500574 288.69 ms 358.34 ms 69.65 ms
04db237 330.16 ms 428.38 ms 98.22 ms
deaeece 347.42 ms 381.10 ms 33.68 ms
61e71ec 343.94 ms 410.59 ms 66.66 ms
df16b96 326.08 ms 391.82 ms 65.74 ms

App size

Revision Plain With Sentry Diff
636cb61 6.27 MiB 7.20 MiB 959.08 KiB
21845e2 5.94 MiB 6.92 MiB 1003.77 KiB
2331d89 5.94 MiB 6.96 MiB 1.02 MiB
f4cc744 5.94 MiB 6.95 MiB 1.01 MiB
1596141 6.16 MiB 7.14 MiB 1003.98 KiB
3500574 6.16 MiB 7.14 MiB 1009.90 KiB
04db237 5.94 MiB 6.95 MiB 1.01 MiB
deaeece 5.94 MiB 6.96 MiB 1.02 MiB
61e71ec 6.34 MiB 7.28 MiB 966.26 KiB
df16b96 6.06 MiB 7.03 MiB 988.94 KiB

@marandaneto
Copy link
Contributor

@marandaneto Hello there! :) Do you know why we specifically tested that GestureRecognizer does not trigger a crumb when containing a button?

'Add crumb for ElevatedButton within a GestureDetector with label',

hello hello, mmm its been a while but IIRC if also adding GestureDetector support and then finding the correct widget wasn't working well because the events will bubble up, for example, finding btn4 instead of btn5 in that case, something like that, could have been an oversight as well, maybe check the PRs and comments/reviews.

@denrase
Copy link
Collaborator Author

denrase commented Jun 3, 2024

@buenaflor Ok, in that case I think it's better if users add breadcrumb tracking for those widgets manually, as I don't think we should change/break the current behaviour. WDYT?

@denrase denrase closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants