Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception aggregate for Android platform exceptions #1998

Closed
wants to merge 10 commits into from

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented Apr 18, 2024

📜 Description

Example: https://jonas-uekotter.sentry.io/share/issue/bd0cdbab9fef4bd8bfffe13517c77288/

@buenaflor @krystofwoldrich I'm not 100% sure whether the result of the changes in this PR is correct, could you double-check whether it's correct? After that, I'll add some tests

💡 Motivation and Context

https://github.com/getsentry/rfcs/blob/main/text/0079-exception-groups.md

Another tiny step towards #1859

💚 How did you test it?

TBD

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

CHANGELOG.md Show resolved Hide resolved
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.24%. Comparing base (fab52eb) to head (0864a24).
Report is 247 commits behind head on release/8.0.0.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/8.0.0    #1998      +/-   ##
=================================================
+ Coverage          88.55%   92.24%   +3.68%     
=================================================
  Files                205       57     -148     
  Lines               6884     1869    -5015     
=================================================
- Hits                6096     1724    -4372     
+ Misses               788      145     -643     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor deleted the branch getsentry:release/8.0.0 April 19, 2024 10:45
@buenaflor buenaflor closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants