-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception aggregate mechanism #1866
Exception aggregate mechanism #1866
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/8.0.0 #1866 +/- ##
===============================================
Coverage 88.55% 88.55%
===============================================
Files 205 218 +13
Lines 6884 7522 +638
===============================================
+ Hits 6096 6661 +565
- Misses 788 861 +73 ☔ View full report in Codecov by Sentry. |
some tests are still failing it looks like |
@buenaflor |
|
@buenaflor Is there something I still need to do here? As far as I can tell, the remaining failing jobs aren't related to this PR. |
I'll merge main into v8 soon and the ci should be green then |
📜 Description
Adds the new field according to https://github.com/getsentry/rfcs/blob/main/text/0079-exception-groups.md#new-mechanism-fields
I didn't yet implement exception aggregates for anything. That can be done in follow-up PRs.
The current CI failures are due to targeting the v8 branch, I believe. At least, I can't see any failures related to the new code.
💡 Motivation and Context
https://github.com/getsentry/rfcs/blob/main/text/0079-exception-groups.md
A tiny step towards #1859
💚 How did you test it?
Updated tests
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps
Use it for PlatformException in the Flutter code.
#skip-changelog