-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Use strlcpy to save session replay info path #4740
base: main
Are you sure you want to change the base?
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
279841c | 1231.41 ms | 1245.65 ms | 14.24 ms |
504730d | 1228.63 ms | 1248.12 ms | 19.49 ms |
c319795 | 1256.18 ms | 1266.87 ms | 10.69 ms |
2affdbd | 1212.78 ms | 1236.60 ms | 23.82 ms |
9e6665f | 1233.33 ms | 1257.14 ms | 23.81 ms |
39b1c35 | 1244.71 ms | 1248.60 ms | 3.89 ms |
f2daa68 | 1211.14 ms | 1217.53 ms | 6.39 ms |
af1f4dd | 1207.33 ms | 1230.04 ms | 22.71 ms |
3396be1 | 1242.29 ms | 1254.41 ms | 12.12 ms |
31ac438 | 1216.17 ms | 1242.68 ms | 26.51 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
279841c | 22.84 KiB | 403.19 KiB | 380.35 KiB |
504730d | 21.58 KiB | 714.88 KiB | 693.30 KiB |
c319795 | 20.76 KiB | 431.99 KiB | 411.22 KiB |
2affdbd | 22.85 KiB | 411.37 KiB | 388.52 KiB |
9e6665f | 22.84 KiB | 403.52 KiB | 380.67 KiB |
39b1c35 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
f2daa68 | 21.58 KiB | 418.40 KiB | 396.82 KiB |
af1f4dd | 22.85 KiB | 414.71 KiB | 391.86 KiB |
3396be1 | 22.30 KiB | 730.07 KiB | 707.77 KiB |
31ac438 | 20.76 KiB | 393.37 KiB | 372.61 KiB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4740 +/- ##
=============================================
+ Coverage 91.118% 91.205% +0.087%
=============================================
Files 623 623
Lines 72484 72499 +15
Branches 25773 26415 +642
=============================================
+ Hits 66046 66123 +77
+ Misses 6343 6276 -67
- Partials 95 100 +5
... and 23 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
📜 Description
Use safer strlcpy and add room for null-terminator when saving sr path for info file.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps