fix(feedback): more accessibility fixes #4727
Open
+16
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armcknight
requested review from
philipphofmann,
brustolin and
philprime
as code owners
1 task
Performance metrics 🚀
|
philipphofmann
approved these changes
Jan 20, 2025
| @@ -80,7 +80,10 @@ extension SentryUserFeedbackFormController { | |||
| } | |||
|
|
|||
| func showedKeyboard(note: Notification) { | |||
| guard let keyboardValue = note.userInfo?[UIResponder.keyboardFrameEndUserInfoKey] as? NSValue else { return } | |||
| guard let keyboardValue = note.userInfo?[UIResponder.keyboardFrameEndUserInfoKey] as? NSValue else { | |||
| SentryLog.warning("Received a keyboard display notification with no frame information.") | |||
There was a problem hiding this comment.
Thanks for the warning 👍
…factor' into armcknight/feat(feedback)/accessibility-fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this has a couple simple fixes that i found i needed to make while refactoring in #4726, and wanted to keep them separate
#skip-changelog