Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style leaderboard page #2

Merged
merged 6 commits into from Mar 10, 2024
Merged

Style leaderboard page #2

merged 6 commits into from Mar 10, 2024

Conversation

benvinegar
Copy link
Collaborator

@benvinegar benvinegar commented Mar 8, 2024

In this PR:

  • Drops email from the column
  • Formats duration and timestamp into something human readable.
  • New design + art assets.
  • Loads Rubik font from Google Fonts (should this be added to the repo and served locally?)

image

Note any rules embedded in this text is just placeholder copy and not the actual rules (we're still deciding).

Some remaining issues (not sure these are blockers though):

  • The design is somewhat responsive, but there's some viewport dimensions where the design breaks down.
  • The footer is "fixed" and it's possible to have content go underneath without triggering scrollbars.
  • The results are still not sorted.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion just fyi, I'll merge as-is

Comment on lines +4 to +11
@functions {
public string FormatTime(TimeSpan duration)
{
// Implement the logic to format the duration as desired
return duration.ToString(@"mm\:ss");
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@functions {
public string FormatTime(TimeSpan duration)
{
// Implement the logic to format the duration as desired
return duration.ToString(@"mm\:ss");
}
}

<tr>
<td>@score.Name</td>
<td>@score.Score</td>
<td>@FormatTime(score.Duration)</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also just call ToString directly on the DateTime reference.

verbatin (@) string isn't needed here)

Suggested change
<td>@FormatTime(score.Duration)</td>
<td>@score.Duration.ToString("mm\:ss")</td>

@bruno-garcia bruno-garcia merged commit 1905728 into main Mar 10, 2024
@bruno-garcia bruno-garcia deleted the styles branch March 10, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants