Custom Metrics in SDKs #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ## Aggregations | ||
|
|
||
| SDKs are expected to aggregate locally for windows of up to 10 seconds. The aggregator shall be |
There was a problem hiding this comment.
I guess that mobile and browser SDKs can apply a different strategy cause the metrics frequency will be lower. One strategy could be to attach these buckets to an already scheduled envelope, which we do for client reports.
|
|
||
| SDKs are expected to aggregate locally for windows of up to 10 seconds. The aggregator shall be | ||
| running in the background and regularly flush out items. Upon shutdown the SDK needs to ensure | ||
| that unflushed buckets are drained. SDKs area also encouraged to ensure that the total aggregation |
There was a problem hiding this comment.
For Mobile, do we need to ensure that we do not lose any buckets when crashing, or is losing some buckets acceptable? I would say losing buckets is unacceptable. One way to achieve this is to sync the buckets across multiple layers, as we already do for the scope.
Co-authored-by: Philipp Hofmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress RFC for how metrics fit into SDKs. I will update motivation and text here shortly.
Rendered RFC