Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for /backup #1309

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add test for /backup #1309

wants to merge 5 commits into from

Conversation

alxndrsn
Copy link
Contributor

Closes #1305

What has been done to verify that this works as intended?

Ran tests.

Why is this the best possible solution? Were any other approaches considered?

There are probably better solutions, like:

  1. checking the backup tar.gz files can be reconstructed
  2. checking the backup actually restores

1 may stray into the realms of testing pg_dump itself.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This change should not affect users.

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

No.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@alxndrsn alxndrsn marked this pull request as ready for review November 27, 2024 06:28
@matthew-white
Copy link
Member

I think this could probably use a rebase now that #1310 is merged.

@alxndrsn
Copy link
Contributor Author

alxndrsn commented Dec 9, 2024

I think this could probably use a rebase now that #1310 is merged.

I will update prior to requesting review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/backup path does not have tests (lib/resources/backup)
2 participants