Test via minio #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, Minio provides one for free. Minio aims to be AWS S3 compatible, so it will do for now
even if this breaks DRY
This reverts commit 011b3bc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we wrote this initially, Amazon S3 was used for tests. This have the caveat that PRs could steal the API keys. Then we secured by only running PRs manually and after manual review.
Now that I do not work on GetNinjas anymore, my keys got revoked and this package tests are broken.
The root problem is AWS not providing disposable test buckets for libraries, and I am not willing to pay AWS just to have this test passing. Nor to mock the interactions to S3 and let it break silently on service changes.
As Minio is a battle-tested S3 implementation and have free buckets for tests, the package tests will be running using it.