Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: calendar widget #2077

Merged
merged 14 commits into from
Sep 28, 2023
Merged

Feature: calendar widget #2077

merged 14 commits into from
Sep 28, 2023

Conversation

denispapec
Copy link
Sponsor Contributor

@denispapec denispapec commented Sep 27, 2023

Proposed change

This PR implements calendar widget, with optional integrations to show events from supported widgets. This PR has support for radarr, sonarr, lidarr and readarr.

Screenshot_20230924_171006

Closes #1243
Closes #1015
Closes #1200

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (please explain)

Checklist:

  • If adding a service widget or a change that requires it, I have added a corresponding PR to the documentation here: Added calendar docs benphelps/homepage-docs#161
  • If adding a new widget I have reviewed the guidelines.
  • If applicable, I have checked that all tests pass with e.g. pnpm lint.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@ozdeadmeat
Copy link

Holy crap this is awesome, when is this coming to the main branch?

Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great overall and really 'just works' out of the box.

I hit a couple tiny bugs at first so fixed those and I made small changes, all individual commits so you can see (we'll squash & merge this anyway).

Only notable change is making it scale width on larger sizes and I made the 'includeSeries' and 'includeAuthor' options default to true, my feeling is it provides a better experience and users can always turn that off if they want.

Great work, let me know if you have any concerns re the above

Screenshot 2023-09-27 at 10 06 20 PM Screenshot 2023-09-27 at 9 08 39 PM Screenshot 2023-09-27 at 9 08 10 PM

@shamoon
Copy link
Collaborator

shamoon commented Sep 28, 2023

Oh yea, I also changed integration to integrations in the widget config =)

@denispapec
Copy link
Sponsor Contributor Author

Those changes looks good, thank you 👍 .
I've pushed another config, but I've noticed issue with that... I think it could be reverted and will push changes when it works properly.

@shamoon
Copy link
Collaborator

shamoon commented Sep 28, 2023

Sorry, what did you mean by your last comment? You want me to revert your last commit? 14e9ce5

@shamoon
Copy link
Collaborator

shamoon commented Sep 28, 2023

(because firstDayInWeek works fine for me in testing)

@denispapec
Copy link
Sponsor Contributor Author

denispapec commented Sep 28, 2023

Sorry, I was in a rush this morning.
After I've noticed that I've pushed config that causes the issue, I wanted to mention that in case you want to merge the widget into main branch, you can revert the last commit without the issue and freely merge.
Btw. issue seems to be that when sunday is firstDayInWeek, it doesn't show me first week at all in this month, it shows Sunday 3rd as first day. I'll have a look this evening and come with a fix or revert :)

@shamoon
Copy link
Collaborator

shamoon commented Sep 28, 2023

Ah yea, I see.

Honestly, Im ok without that anyway, lets merge it 💪

@shamoon shamoon merged commit 4cd4103 into gethomepage:main Sep 28, 2023
1 check passed
@Shagon94
Copy link
Contributor

@denispapec would it be possible to implement a button that will go to the current date? For example, by clicking on the "Calendar" we could go back to the current date. This is useful once you go back or forward a few months and want to go back. Workaround for this is to just refresh the page.

image

@Nonoss117
Copy link
Contributor

@denispapec , I posted a new feature request here: #2086

Thanks for this awesome widget

@Ramss3s
Copy link

Ramss3s commented Sep 30, 2023

how can i put the rest of links in right?
Screenshot 2023-09-30 172945

@shamoon
Copy link
Collaborator

shamoon commented Sep 30, 2023

Commenting on closed PRs is not the way to make a feature or get help.

to answer your q, those links in the screenshot are just other services in a column next to the calendar

@gethomepage gethomepage locked as resolved and limited conversation to collaborators Sep 30, 2023
@denispapec denispapec deleted the calendar branch May 5, 2024 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants