Be more forgiving of incorrect SampleFormat length #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alues populated, such as in bioformats ome tif files
jeffpeck10x
force-pushed
the
more-forgiving-tiff-reading
branch
from
fa75154 to
e2aed8b
Compare
|
Seems related/similar to #303 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address the issue noted in:
#159
and allows geotiff to handle a situation where there is an interleaved tiff that has
SampleFormatof[1], despite there being multiple samples per channel.The situation described in the issue is that
BitsPerSampleis[8, 8, 8], yetSampleFormatis only[1], whereas it should have the same number of values (i.e.[1, 1, 1]). Rather than fail in this situation, be more forgiving of the incorrect format and try to infer from the value that was set.This was noticed in some OME-TIFF files generated by qupath with
Creator="OME Bio-Formats 6.11.1"in the OME-XML. These files can be opened by qupath, FIJI, and Python's tifffie, so it only makes sense thatgeotiff.jsshould handle them as well, despite the incorrectSampleFormatlength.