Skip to content

Commit

Permalink
Merge pull request #416 from pavelvasev/fix_credentials
Browse files Browse the repository at this point in the history
Bugfix: remove needless credentials argument
  • Loading branch information
constantinius authored Jan 19, 2024
2 parents b646d0b + 6855954 commit 4539582
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/source/client/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ export class BaseClient {

/**
* Send a request with the options
* @param {{headers: HeadersInit, credentials: RequestCredentials, signal: AbortSignal}} [options={}]
* @param {{headers: HeadersInit, signal: AbortSignal}} [options={}]
* @returns {Promise<BaseResponse>}
*/
async request({ headers, credentials, signal } = {}) { // eslint-disable-line no-unused-vars
async request({ headers, signal } = {}) { // eslint-disable-line no-unused-vars
throw new Error('request is not implemented');
}
}
6 changes: 3 additions & 3 deletions src/source/client/fetch.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ export class FetchClient extends BaseClient {
}

/**
* @param {{headers: HeadersInit, credentials: RequestCredentials, signal: AbortSignal}} [options={}]
* @param {{headers: HeadersInit, signal: AbortSignal}} [options={}]
* @returns {Promise<FetchResponse>}
*/
async request({ headers, credentials, signal } = {}) {
async request({ headers, signal } = {}) {
const response = await fetch(this.url, {
headers, credentials, signal,
headers, credentials: this.credentials, signal,
});
return new FetchResponse(response);
}
Expand Down

0 comments on commit 4539582

Please sign in to comment.