-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARISTOTLE: add a plot of the rupture, including names of populated places #10107
Open
ptormene
wants to merge
21
commits into
master
Choose a base branch
from
plotrup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g shakemap or finite-fault
micheles
reviewed
Oct 31, 2024
:returns: a DataFrame of points corresponding to populated places | ||
""" | ||
mosaic_dir = config.directory.mosaic_dir | ||
fname = os.path.join(mosaic_dir, 'worldcities.csv') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should put the content of worldcities.csv inside exposure.hdf5, so that we would depend on a single file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrieving the rupture data, a plot of the rupture is displayed if available (without needing to run the calculation).
I'm also including the names of populated places, making it easier to identify the location in the map.
This is a first step, that includes the implementation of the infrastructure to display images below the button to retrieve rupture data after pressing it.
The next step will be to replace this plot with those displaying PGA and MMI.