Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched from http to https for ca-cert download #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switched from http to https for ca-cert download #81

wants to merge 1 commit into from

Conversation

velenux
Copy link
Contributor

@velenux velenux commented Jul 2, 2021

Since it is such a sensitive file, it probably makes sense to download it via https.

@geerlingguy
Copy link
Owner

Is there a chance this would fail if the current certs are out of date?

@velenux
Copy link
Contributor Author

velenux commented Jul 5, 2021

Is there a chance this would fail if the current certs are out of date?

yes.
One alternative could be to download the file first, then make a basic sanity check (with openssl for example) before overwriting the original one, so you can still use https but keep the file as it is if the download fails. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@velenux @geerlingguy