Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom data dir #206

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Custom data dir #206

wants to merge 3 commits into from

Conversation

misilot
Copy link

@misilot misilot commented Mar 24, 2022

Fixes bugs #158, #40, #124 allowing for a custom data directory

This is a rebased version of #160, and #179

@stale
Copy link

stale bot commented Jun 23, 2022

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Jun 23, 2022
@lingfish
Copy link

Rather, unless something is breaking stability (e.g. a project I maintain won't install anymore, or breaks completely and CI blows up), or there's a major feature or missing component that I agree would be a no-brainer to have incorporated

I reckon this is a no-brainer.

@stale
Copy link

stale bot commented Jul 19, 2022

This issue is no longer marked for closure.

@stale stale bot removed the stale label Jul 19, 2022
@misilot misilot force-pushed the custom-data-dir branch 2 times, most recently from bbf898e to 86e0075 Compare July 19, 2022 00:51
@misilot
Copy link
Author

misilot commented Aug 2, 2022

@geerlingguy any chance of this being merged?

The biggest use case for this is we can put it onto a separate volume than root without having all of /var in a separate disk in AWS.

@misilot
Copy link
Author

misilot commented Oct 11, 2022 via email

@lantrix
Copy link

lantrix commented Nov 1, 2022

I've tested this and it works well just by setting this in the config/vars:

postgresql_data_dir: "/data/pgsql/{{ postgresql_version }}/data"

Much easier to move the data to another mounted volume

lantrix added a commit to lantrix/terraform-ec2-ssm that referenced this pull request Nov 1, 2022
@lantrix
Early implement geerlingguy/ansible-role-postgresql#206
705b100
@stale
Copy link

stale bot commented Feb 18, 2023

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Feb 18, 2023
@misilot
Copy link
Author

misilot commented Feb 18, 2023

Still not stale :)

@stale
Copy link

stale bot commented Feb 18, 2023

This issue is no longer marked for closure.

@stale stale bot removed the stale label Feb 18, 2023
geerlingguy
geerlingguy reviewed Feb 21, 2023
View reviewed changes
tasks/main.yml Outdated Show resolved Hide resolved
@misilot misilot force-pushed the custom-data-dir branch 2 times, most recently from 3e45eab to ec3e0d4 Compare February 21, 2023 05:00
@stale
Copy link

stale bot commented Jun 17, 2023

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Jun 17, 2023
@misilot
Copy link
Author

misilot commented Jun 18, 2023 via email

@stale
Copy link

stale bot commented Jun 18, 2023

This issue is no longer marked for closure.

@stale stale bot removed the stale label Jun 18, 2023
@misilot
Copy link
Author

misilot commented Jun 26, 2023

I ended up adding a custom data directory to the molecule tests, which is why everything else is failing in the PR.

What would be the best way to handle the __postgresql_config_path: "/var/lib/pgsql/data" that won't exist if you use a custom directory? Would it make sense to have __postgresql_config_path: be __postgresql_config_path: "{{ postgresql_data_dir }}"?

@github-actions
Copy link

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions bot added the stale label Oct 27, 2023
@misilot
Copy link
Author

misilot commented Oct 27, 2023 via email

@github-actions github-actions bot removed the stale label Nov 3, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions bot added the stale label Mar 8, 2024
@misilot
Copy link
Author

misilot commented Mar 10, 2024

no stale

@misilot
Copy link
Author

misilot commented Mar 10, 2024

So it's failing on the EL versions because __postgresql_config_path is defaulting to the old data directory I believe?

Is there a way in molecule to have specific variables for the different distros?

@github-actions github-actions bot removed the stale label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geerlingguy geerlingguy geerlingguy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@misilot @lingfish @lantrix @geerlingguy @jeanmonet