Rework how "EXTERNALLY-MANAGED" are handle using flag pip_externally_managed
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
socheatsok78
commented
May 16, 2024
Comment on lines
+4
to
+13
| - name: Get installed python3 version | ||
| ansible.builtin.shell: python3 --version | awk '{split($2, a, "."); print a[1] "." a[2]}' | ||
| register: py3ver | ||
| changed_when: false | ||
|
|
||
| - name: Ensure "{{ 'absent' if not pip_externally_managed else 'present' }}" of EXTERNALLY-MANAGED's Python base environments | ||
| ansible.builtin.file: | ||
| path: "/usr/lib/python{{ py3ver.stdout }}/EXTERNALLY-MANAGED" | ||
| state: "{{ 'absent' if not pip_externally_managed else 'touch' }}" | ||
| when: py3ver is defined and py3ver.stdout is version_compare('3.11', '>=') |
There was a problem hiding this comment.
I have other implementation which could replace this whole thing
- name: Ensure "{{ 'absent' if not pip_externally_managed else 'present' }}" of EXTERNALLY-MANAGED's Python base environments
vars:
python_version: "{{ ansible_facts.python_version }}"
python_version_short: "{{ ansible_facts.python.version.major }}.{{ ansible_facts.python.version.minor }}"
ansible.builtin.file:
path: "/usr/lib/python{{ python_version_short }}/EXTERNALLY-MANAGED"
state: "{{ 'absent' if not pip_externally_managed else 'touch' }}"
when: python_version is defined and python_version is version_compare('3.11', '>=')Which do you think is a better fit for this? @geerlingguy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to control how "EXTERNALLY-MANAGED" python base environment via flag
pip_externally_managed(boolean).If
pip_externally_managed: true, we preserver or create theEXTERNALLY-MANAGEDfile in it intended place. Otherwise remove it as original impl.I'm not entirely sure if it is the right way to do this, but i'm open to suggestion.
Ref #57 (comment)