Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #490

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Fix tests #490

merged 2 commits into from
Jan 11, 2025

Conversation

mateusfpleite
Copy link
Collaborator

@mateusfpleite mateusfpleite commented Jan 9, 2025

TestFixtures file is not compiling. This PR fix this and a small failure in the News test caused by recent changes.

@mateusfpleite mateusfpleite requested a review from katjam January 9, 2025 22:59
@mateusfpleite mateusfpleite self-assigned this Jan 9, 2025
Copy link

Deploying the-trans-dimension with  Cloudflare Pages  Cloudflare Pages

Latest commit: a9afd5b
Status: ✅  Deploy successful!
Preview URL: https://97e68b40.the-trans-dimension.pages.dev
Branch Preview URL: https://tests-fix-tests.the-trans-dimension.pages.dev

View logs

Copy link
Member

@katjam katjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! There's another issue around improving tests - like to make them meaningful in any way if you ever fancy dabbling in that.

@mateusfpleite
Copy link
Collaborator Author

@katjam I'll keep this in mind for the future. I'm still getting used to the project, so I probably wouldn't be able to do very meaningful testing without explicit guidance for now, but I'll at least try to add good tests to new features

@mateusfpleite mateusfpleite merged commit 308f29c into main Jan 11, 2025
1 check passed
@mateusfpleite mateusfpleite deleted the tests/fix-tests branch January 11, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants