Improve Find/Replace dialog errors #3841
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move fail branch to first use. Focus replace entry if escaping failed.
The background can be set again if necessary.
Show status message when there's no search text. Don't error when find & replace text are the same and regex is enabled. Also set replace background when find & replace text are the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3828, please merge that first.
Show status message when there's no search text - like Find in Files does.
Don't error when find & replace text are the same and regex is enabled. E.g. when using
\1in replace text, the result is not the same.Also set replace background when find & replace text are the same.