Fix vlsir tests #188
Closed
Fix vlsir tests #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This appears unrelated maybe re-running should work? |
nikosavola
force-pushed
the
187-fix-test-vlsir
branch
from
4c2c526 to
450b543
Compare
|
This can be drafted until #189 is fixed to see if the tests work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the vlsir test failing if the whole test suite is run. The problem stemmed from the meow plugin modifying layers in the active pdk while not adding corresponding LayerViews.
The solution implemented here is to reload gdsfactory after running the meow tests.
Drafted until test confirmed to run.
Closes #187