Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse Ellipse extrusionDirection #87

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FishOrBear
Copy link

No description provided.

@FishOrBear
Copy link
Author

210 220 230 is generic, maybe we should optimize the code.

@camnewnham
Copy link
Contributor

This should use helpers.parsePoint(scanner) . You can see an example of it in use here:

case 10: // X coordinate of 'first alignment point'
entity.anchorPoint = helpers.parsePoint(scanner);
break;

Copy link
Member

@bzuillsmith bzuillsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment here #87 (comment)

@FishOrBear
Copy link
Author

image

I know this, but there seem to be two ways of handling this 210 in this library, should we unify the code?

@bzuillsmith
Copy link
Member

Any new code should really parse such coordinates into a point object. The 3 extrusionDirection properties were left over from an early iteration of the project and I didn't want to introduce a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants