Issue 3817 Update default values and descriptions for concurrency properties #3820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaffer01
reviewed
Nov 28, 2024
| @@ -347,11 +347,11 @@ public interface DefaultProperty { | |||
| .propertyGroup(InstancePropertyGroup.DEFAULT).build(); | |||
| UserDefinedInstanceProperty DEFAULT_LAMBDA_CONCURRENCY_MAXIMUM = Index.propertyBuilder("sleeper.default.lambda.concurrency.max") | |||
| .description("Default value for the maximum concurrency for each lambda within the Sleeper instance. " + | |||
| "By default the maximum concurrency is unlimited. Each lambda also has its own property that " + | |||
| "By default the maximum concurrency is set 10 concurrent tables. Each lambda also has its own property that " + | |||
There was a problem hiding this comment.
I think this would read better as "is set to 10 which is enough for 10 online tables. If there are more online tables this number may need to be increased".
patchwork01
reviewed
Nov 29, 2024
| "See reserved concurrency overview at: https://docs.aws.amazon.com/lambda/latest/dg/configuration-concurrency.html") | ||
| .defaultValue("10") |
There was a problem hiding this comment.
This isn't being applied because the default property is still set. That needs to be removed.
| @@ -358,7 +358,9 @@ public interface CommonProperty { | |||
| UserDefinedInstanceProperty STATESTORE_COMMITTER_LAMBDA_CONCURRENCY_RESERVED = Index.propertyBuilder("sleeper.statestore.committer.concurrency.reserved") | |||
| .defaultProperty(DEFAULT_LAMBDA_CONCURRENCY_RESERVED) | |||
| .description("The reserved concurrency for the state store committer lambda.\n" + | |||
| "Presently this value defaults to 10 to align with expectations around table efficiency. \n" + | |||
There was a problem hiding this comment.
We could explain this is to ensure state store operations can be applied to at least 10 tables even when concurrency is used up in the account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Issue
PR"
Tests
Documentation
separate issue for that below.