Remove keyoverride attribute from additional link tags #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nariakiraHara
commented
May 14, 2024
| @@ -61,7 +61,7 @@ If you are using **`pages`** directory then `NextSeo` is **exactly what you need | |||
| - [dangerouslySetAllPagesToNoFollow](#dangerouslysetallpagestonofollow) | |||
| - [robotsProps](#robotsprops) | |||
| - [Twitter](#twitter) | |||
| - [facebook](#facebook) | |||
| - [Facebook](#facebook) | |||
There was a problem hiding this comment.
Probably changes by doctoc
|
I'd love to see this merged 🙏 |
|
Hey @garmeeh, I've worked on this one and it'd be nice if you can check it out. |
|
@garmeeh This PR is exactly what I need! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s):
Stops the keyOverride prop for additionalLinkTags being rendered as a keyoverride attribute.
#1474
Related issue and PR
To help get PR's merged faster, the following is required:
[] Updated the documentation
[x] Unit/Cypress test covering all cases
Please link to relevant Google Docs or schema.org docs for what you are adding so we can review.
Please have a read of the Contributing Guide for full details.
https://github.com/garmeeh/next-seo/blob/master/CONTRIBUTING.md