Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing matrix #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update testing matrix #105

wants to merge 1 commit into from

Conversation

rnelson0
Copy link
Contributor

Ruby 1.8.7 is EOL and is no longer in the Puppet Labs testing chain
Remove Puppet 2.7.0
Add Puppet 3.8.0-4.3.0
Trim excludes to match updated testing versions

@rnelson0
Copy link
Contributor Author

Personally I'd love to remove <3.5 but I'm not sure that's worth tossing out quite yet. I also know many modules only test 4.0.0 or the latest 4.x.0 but there ARE some differences between 4.x versions that have bit me before.

@beddari
Copy link

beddari commented Mar 15, 2016

My experience is that the matrix shipped here is waaaay beyond expectations ;-) My vote would be to 1) slim it down a lot 2) ship a new major version soon that pushes for 4.x and allows failures when future parser is off. But this is @garethr's call :)

@rnelson0
Copy link
Contributor Author

@beddari I've recently switched to only ~> 3.0 and ~>4.0 in my own modules based on voxpupuli work. Is that close to your expectations?

I kinda forgot about this but should probably update it again before asking @garethr to merge it!

@beddari
Copy link

beddari commented Mar 15, 2016

@rnelson0 Yes. Today with open source Puppet my matrix is only Ruby 1.9.3 and 2.0.0 with 3.8.x, then a single 4.x.0, yes. I've not had enough exposure to hit differences between 4.x versions (yet?).

@rnelson0
Copy link
Contributor Author

@garethr This is a bit more trim now and reflective of what many forge modules use for testing now, without being too excessive.

@beddari
Copy link

beddari commented Mar 15, 2016

👍

  Ruby 1.8.7 is EOL and is no longer in the Puppet Labs testing chain
  Test only the latest 3.x and 4.x versions with Ruby 1.9.3 and 2.1.0, with strict variables
@cdenneen
Copy link
Contributor

cdenneen commented Apr 2, 2016

@rnelson0 @beddari while I like the idea of tighter matrix for people using PE shouldn't we be testing the 4.x.x versions shipped with PE? Or at least the latest versions of 2015.N.X and soon to be 2016.N.1(4.4.1)?
All of those users won't be able to update their puppet or ruby since they are vendored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants