This repository has been archived by the owner on Jun 9, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is this PR doing?
added a commandline option
--filename
to allow overriding thestdin
filename displayed when accepting manifests from standard inputwhy is it useful/desireable?
I have a loop that kinda looks like the below (pseudo)shell example. A Helm template is rendered to a temporary file (greatly simplified here for brevity) so that the test output displays a filename for any failed tests.
The
--filename
option provided by this PR allows me to delete all the temporary file handling (mktemp
etc) and simply pipe the output ofhelm template ...
directly tokubetest
.behavioural changes
The default behaviour of
kubetest
is not affected by this PR.