Move machine-controller-manager-provider-local into gardener/gardener
#9782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/dev-productivity
gardener-prow
bot
added
the
size/XL
timebertt
force-pushed
the
hackathon-mcm-provider-local
branch
2 times, most recently
from
7946b88
to
34f7c08
Compare
|
/retest |
gardener-prow
bot
added
the
needs-rebase
|
/assign |
plkokanov
requested changes
May 17, 2024
timebertt
force-pushed
the
hackathon-mcm-provider-local
branch
from
34f7c08
to
621ac85
Compare
gardener-prow
bot
removed
the
needs-rebase
|
Thanks for your review @plkokanov. I rebased and addressed your suggestions. |
timebertt
force-pushed
the
hackathon-mcm-provider-local
branch
from
621ac85
to
394a3e9
Compare
timebertt
force-pushed
the
hackathon-mcm-provider-local
branch
2 times, most recently
from
58faa01
to
d0841b0
Compare
rfranzke
force-pushed
the
hackathon-mcm-provider-local
branch
from
d0841b0
to
f1e68e6
Compare
Co-Authored-By: Rafael Franzke <[email protected]> Co-Authored-By: Marcel Boehm <[email protected]>
Co-Authored-By: Rafael Franzke <[email protected]> Co-Authored-By: Marcel Boehm <[email protected]>
Co-Authored-By: Rafael Franzke <[email protected]> Co-Authored-By: Marcel Boehm <[email protected]>
Co-Authored-By: Rafael Franzke <[email protected]> Co-Authored-By: Marcel Boehm <[email protected]>
Co-Authored-By: Rafael Franzke <[email protected]> Co-Authored-By: Marcel Boehm <[email protected]>
Co-Authored-By: Rafael Franzke <[email protected]> Co-Authored-By: Marcel Boehm <[email protected]>
Co-Authored-By: Rafael Franzke <[email protected]> Co-Authored-By: Marcel Boehm <[email protected]>
Image is always provided by the kind cluster config yaml. Hence, this `--image` flag never had any effect because it was always overwritten. Co-Authored-By: Rafael Franzke <[email protected]> Co-Authored-By: Marcel Boehm <[email protected]>
rfranzke
force-pushed
the
hackathon-mcm-provider-local
branch
from
f1e68e6
to
7ec12fe
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: b4758f05ababcbfeb07d2edef73106e97d44a533
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity
/kind enhancement
What this PR does / why we need it:
In order to improve development productivity, this PR moves the content of the https://github.com/gardener/machine-controller-manager-provider-local repository into
gardener/gardener. The images are built dynamically with Skaffold and pushed into the local registry.On the way, we
skaffold.yamlfile (removing theeurope-docker.pkg.dev/*prefixes since these images are never actually pushed to this real remote registrylogcheckgolangci-lintplugin to prevent false positive findings in case a package-level functions disguises aslogrmethodRelease note: