[GEP-19] Delete networkingv1.Ingress instead of networkingv1beta1.Ingress
#9299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/monitoring
46 tasks
gardener-prow
bot
added
the
size/XS
rickardsjp
approved these changes
Mar 4, 2024
|
LGTM label has been added. Git tree hash: 6db8b39dd9f364e18d1e9547d14a91a2ce281669
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rickardsjp, ScheererJ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area monitoring
/kind bug
What this PR does / why we need it:
After #9200, the old
Ingressrelated toaggregate-prometheusis not deleted on clusters that don't serve thenetworking.k8s.io/v1beta1API anymore. Actually, it was never intended to use this API but onlynetworking.k8s.io/v1. Thanks to the IDE!Which issue(s) this PR fixes:
Part of #9065
Follow-up of f7babde#diff-a3bc9d8bf428d542a1668556adcba0143538e5af8dad225753b26953049ceb18
Special notes for your reviewer:
/cc @ScheererJ @rickardsjp
Release note: