Trying to implement postgresql #1183
Open
+171
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It still somehow fails: |
|
with the driver "org.postgresql.ds.PGSimpleDataSource" the same result :( |
|
getting closer to success: today i learned sql syntax of mysql is different to mysql of postgresql? |
Yes SQLite, MySQL and PostgresSQL are all slightly different.
Well the driver has to be available too. Spigot provides both drivers in their jar. |
|
@games647 can you help me debug the plugin? I get an internal error when using /premium: I dont see any of my new sources in the stack, where is the error? what query fails to run? |
This means there is an earlier error that caused the plugin to disable itself before anything bad happens. |
|
found out that the plugin is disabled because ProtocolLib was missing on my test server |
|
The postgres implementation works like a charm, I guess it is ready for review and approval now
|
0xFEEDC0DE64
force-pushed
the
add-postgresql
branch
from
4efc658
to
56e43fb
Compare
|
I have squashed all my commits into a single clean commit |
|
another exception appeared on my live server: will debug this now |
|
I have no idea why the uuid parser fails with postgres but not with sqlite the string is identical, I checked using log statements |
|
There could be space inside the UUID string. |
|
this is with postgresql (I have added new log statements to show the exact string that is parsed): this is with sqlite: the new log statements are placed there: I really see no difference, does CharSequence work different with postgres? can we use String instead? |
|
you were right, there were additional Spaces at the end, I have no idea how they got introduced but non the less I think trimming the String is always a good idea, see my latest commit |
|
One issue I have this code is that we are still required to include the PostgreSQL driver. Otherwise it wouldn't work. This project already include many other dependencies that I would consider this worth it. |
|
How does it work on my spigot server now? I didnt add any drivers as far as I know |
|
The driver could be provided by another plugin like AuthMe. It includes that driver. |
|
are you ok with adding the same driver to your plugin? |
|
Well, this plugin nowadays already comes near the maximum file size that Spigot allows. Creating an universal jar of all platform modules (e.g. Spigot) could shrink the size again. Furthermore, it would be possible to uses Spigot's 1.16 library loader, but dynamic dependency also has its downsides like increased startup time and requires additional downloads from Maven per server instead of once for downloading this plugin. Maybe, we could also merges this and make it usable if the driver is already made available by another plugin like AuthMe. Could you maybe explain shortly what makes you prefer Postgres over the other two? This isn't really a highly requested feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to implement postgres for #1182 myself.
Disclaimer: I have never seen or written Java before this pull request and I have no idea how to compile the sources to a working .jar file for my minecraft server.
But I hope that at least CI runs will check the syntax and if it compiles correctly?
Please help me finish this pull request :)