chore: add local serve command #2521
Conversation
WalkthroughThe pull request introduces a new development script in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
package.json (1)
13-13: Consider consolidating watch scripts to reduce duplication.The new "dev" script is very similar to the existing "watch" script, differing only in NODE_ENV. Consider using a single script with an environment parameter.
- "watch": "cross-env NODE_ENV=release BUILD_TYPE=MODULE rollup -cw -m inline", - "dev": "cross-env NODE_ENV=development BUILD_TYPE=MODULE rollup -cw -m inline", + "watch": "cross-env BUILD_TYPE=MODULE rollup -cw -m inline", + "dev": "cross-env NODE_ENV=development pnpm watch", + "watch:prod": "cross-env NODE_ENV=release pnpm watch",Also applies to: 15-15
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: build (22.x, windows-latest)
- GitHub Check: e2e (22.x)
- GitHub Check: codecov
| @@ -12,6 +12,7 @@ | |||
| "lint": "eslint packages/*/src --ext .ts", | |||
| "watch": "cross-env NODE_ENV=release BUILD_TYPE=MODULE rollup -cw -m inline", | |||
| "watch:umd": "cross-env NODE_ENV=release BUILD_TYPE=UMD rollup -cw -m inline", | |||
| "dev": "cross-env NODE_ENV=development BUILD_TYPE=MODULE rollup -cw -m inline", | |||
There was a problem hiding this comment.
Add serve functionality to match PR objectives.
The PR title mentions adding a local serve command, but the new "dev" script doesn't include any server functionality. Consider utilizing the rollup-plugin-serve package that's already listed in devDependencies.
Here's how to add server functionality:
- "dev": "cross-env NODE_ENV=development BUILD_TYPE=MODULE rollup -cw -m inline",
+ "dev": "cross-env NODE_ENV=development BUILD_TYPE=MODULE rollup -cw -m inline --config rollup.config.serve.js",Then create a new rollup.config.serve.js that extends your base config and adds the serve plugin:
import serve from 'rollup-plugin-serve';
import baseConfig from './rollup.config.js';
export default {
...baseConfig,
plugins: [
...baseConfig.plugins,
serve({
contentBase: 'dist',
port: 3000
})
]
};
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2521 +/- ##
==========================================
- Coverage 69.01% 68.58% -0.44%
==========================================
Files 957 957
Lines 100052 100068 +16
Branches 8554 8563 +9
==========================================
- Hits 69054 68628 -426
- Misses 30742 31184 +442
Partials 256 256
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit