Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding swagger #287

Merged
merged 12 commits into from
Aug 12, 2020
Merged

Adding swagger #287

merged 12 commits into from
Aug 12, 2020

Conversation

Skarlso
Copy link
Member

@Skarlso Skarlso commented Aug 11, 2020

Generate the docs:

swag init -g ./cmd/gaia/main.go

Then view:

https://gaia.whatever.com/api/v1/swagger/index.html

@Skarlso
Copy link
Member Author

Skarlso commented Aug 11, 2020

This will now fix #150.

@Skarlso
Copy link
Member Author

Skarlso commented Aug 12, 2020

@speza Doing this I found a little mix-up in the rbac endpoints. :) It looks like you were using the wrong handler for one of the endpoints also the naming and comments of some other handlers were wrong which I didn't spot either. :D I fixed them in this PR. :)

@Skarlso
Copy link
Member Author

Skarlso commented Aug 12, 2020

Hey @speza.

Do we still use this? apiAuthGrp.GET("permission", PermissionGetAll).

@Skarlso
Copy link
Member Author

Skarlso commented Aug 12, 2020

/test

@gaia-bot
Copy link

Command received. Building new test image.

@gaia-bot
Copy link

The new test version has been pushed.

@Skarlso
Copy link
Member Author

Skarlso commented Aug 12, 2020

Nice! This works perfectly fine. :)

@Skarlso Skarlso merged commit 165df8f into gaia-pipeline:master Aug 12, 2020
@speza
Copy link
Contributor

speza commented Aug 12, 2020

Ah nice! It was so much manual work I can believe I got something wrong haha.

That old permissions endpoint is still being used if anyone used legacy perms. Still used in the UI until we deprecate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants