Merge pull request owasp-modsecurity#3016 from M4tteoP/uri_decode_inv…

…alid fix: makes uri decode platform independent
fzipi · Mar 5, 2024 · 6d719be · 6d719be
2 parents 5a6a538 + fcf205d
commit 6d719be
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/utils/decode.cc b/src/utils/decode.cc
@@ -99,8 +99,8 @@ std::string uri_decode(const std::string & sSrc) {
     while (pSrc < SRC_LAST_DEC) {
         if (*pSrc == '%') {
             char dec1, dec2;
-            if (-1 != (dec1 = string::HEX2DEC[*(pSrc + 1)])
-                && -1 != (dec2 = string::HEX2DEC[*(pSrc + 2)])) {
+            if ((char)-1 != (dec1 = string::HEX2DEC[*(pSrc + 1)])
+                && (char)-1 != (dec2 = string::HEX2DEC[*(pSrc + 2)])) {
                 *pEnd++ = (dec1 << 4) + dec2;
                 pSrc += 3;
                 continue;