RFC: Add caches to avoid recomputing MinSize multiple times #4681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a request for comments about adding an automatic and built-in cache for MinSize values in BaseWidget and containers. This avoids having to recalculate the size by walking the entire tree of objects each time. It does incur a slight change of behaviours for widgets that overwrite the
MinSize()
method and use the size given from the BaseWidget to add or subtract to. I have updated all widgets to make sure that the renderer defines the needed MinSize and as such all widgets are updated to use the cache.Checklist:
Where applicable: