Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect theme variant for Gnome and KDE #3414

Merged
merged 13 commits into from
Nov 29, 2022
Merged

Detect theme variant for Gnome and KDE #3414

merged 13 commits into from
Nov 29, 2022

Commits on Nov 19, 2022

  1. Detect theme variant for Gnome and KDE 

    - For Gnome, read values from `gsettings` to get the color-scheme (can
  be prefer-dark, prefer-light or "default"
- For KDE, read the kdeglobals file and calculate the brightness if the
  theme is not the standard one - this method can also be applied for
  older Gnome version reading GTK themes, but is this useful?
- Theme change detection:
    - Gnome: connect to dbus and wait for theme change
    - KDE, no idea at this time, but switching from KDE to Gnome has
      changed the Gnome theme... So maybe KDE is using dbus too.
    @metal3d
    metal3d committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    f1a848a View commit details
    Browse the repository at this point in the history

  2. Fix a bad syntax listening dbus event chan

    @metal3d
    metal3d committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    45bbbdc View commit details
    Browse the repository at this point in the history

  3. Fix function name and theme switch

    @metal3d
    metal3d committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    dfbbd8d View commit details
    Browse the repository at this point in the history

  4. Make functions to parse color and brightness

    @metal3d
    metal3d committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    7bf9848 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2022

  1. Use DBus instead of gsettings to get the variant

    @metal3d
    metal3d committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    4b64bf8 View commit details
    Browse the repository at this point in the history

  2. Fix bad doc comment

    @metal3d
    metal3d committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    537a263 View commit details
    Browse the repository at this point in the history

  3. Fix unused error variable

    @metal3d
    metal3d committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    4e98a8c View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Detect variant for modern desktop manager 

    - Gnome already makes use of color-scheme from freedesktop portal
  settings
- KDE should provide the value in current and next version - waiting for
  it: fallback to dark theme variant
- For all others desktop managers, fallback to dark theme variant
    @metal3d
    metal3d committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    5105094 View commit details
    Browse the repository at this point in the history

  2. Remove redondant case

    @metal3d
    metal3d committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    a38d7ec View commit details
    Browse the repository at this point in the history

  3. Break on reached wanted message

    @metal3d
    metal3d committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    15957da View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Use Fyne.LogError

    @metal3d
    metal3d committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    014f66f View commit details
    Browse the repository at this point in the history

  2. No need size of 10 in chan

    @metal3d
    metal3d committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    d079c2f View commit details
    Browse the repository at this point in the history

  3. No need to set size...

    @metal3d
    metal3d committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    57d1aa9 View commit details
    Browse the repository at this point in the history