Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix responsive #79

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Fix responsive #79

wants to merge 15 commits into from

Commits on Oct 30, 2023

  1. Use pure fraction

    @metal3d
    metal3d committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    ef32303 View commit details
    Browse the repository at this point in the history

  2. Fix responsive problems 

    - The padding were not respected between element in a line and stepping
  to the next line
- We now prefer move the first element in a row to the X padding, to
  avoid computation - the responsive behavior is to center elements in a
  row, so it must be OK
- We accept now that a non-responsive element is added to the container,
  it will be resized to the default 100% of the container width
- We previously use the window size to compute the reponsive element
  sizes. That's an error... The reponsivity should be set to the
  container size. That fixed now.
    @metal3d
    metal3d committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    369c47f View commit details
    Browse the repository at this point in the history

  3. Add docstring on size constants

    @metal3d
    metal3d committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    a562475 View commit details
    Browse the repository at this point in the history

  4. Badly named the OneFith in docstring

    @metal3d
    metal3d committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    8f0433f View commit details
    Browse the repository at this point in the history

  5. One more badly named variable...

    @metal3d
    metal3d committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    357d2d1 View commit details
    Browse the repository at this point in the history

  6. Fixes and enhanements

    @metal3d
    metal3d committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    6770176 View commit details
    Browse the repository at this point in the history

  7. Make it a real container and optimize computation

    @metal3d
    metal3d committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    b01b4a2 View commit details
    Browse the repository at this point in the history

  8. Fixup error message

    @metal3d
    metal3d committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    a506a30 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Fixing bad behaviors on detected sizes

    @metal3d
    metal3d committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    55814e5 View commit details
    Browse the repository at this point in the history

  2. Fix doc

    @metal3d
    metal3d committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    17f5eab View commit details
    Browse the repository at this point in the history

  3. Add needed documentation on FractionHelper

    @metal3d
    metal3d committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    06e8c36 View commit details
    Browse the repository at this point in the history

  4. Use function instead of const 

    Constants needs initial computation. Prefer using functions
    @metal3d
    metal3d committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    b67aa39 View commit details
    Browse the repository at this point in the history

  5. Add doc

    @metal3d
    metal3d committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    c739ddd View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Send objects in container constructor 

    As suggested here: https://github.com/fyne-io/fyne-x/pull/79/files/c739ddd59ceaa5ce4b487b7ed0afce7bd6968b96#r1392113638
    @metal3d
    metal3d committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    604c92b View commit details
    Browse the repository at this point in the history

  2. Cleanup dead code 

    As suggested at https://github.com/fyne-io/fyne-x/pull/79/files/c739ddd59ceaa5ce4b487b7ed0afce7bd6968b96#r1392120097
    @metal3d
    metal3d committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    58f4884 View commit details
    Browse the repository at this point in the history