Fix crash in CompletionEntry #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andydotxyz
reviewed
Feb 17, 2023
| @@ -162,6 +162,9 @@ func newNavigableList(items []string, entry *widget.Entry, setTextFromMenu func( | |||
| fn(i, o) | |||
| return | |||
| } | |||
| if i < 0 || i >= widget.ListItemID(len(n.items)) { | |||
There was a problem hiding this comment.
Thanks for this fix, but I do wonder - should we guard the fn call above as well? It won't crash immediately but we may be leading the callback to crash or get unexpected callback data...
There was a problem hiding this comment.
What do you think @sharki13 could you move it so the fn callback does not get invalid data as well?
There was a problem hiding this comment.
Can this questions be answered @sharki13 ? It does seem like a good thing to have fixed.
Jacalz
changed the title
|
Just pinging on this to see if the suggested change could be made so this can be landed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #38
From time to time there is a crash during typing something to entry, while list of options is modified basis on entered text.
While
UpdateItemis executed,n.itemsslice is shorter than indexiindicates, which lead to crash.