DRAFT: Making it compatible with composer ^2.5 as php is throwing an error. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the desc. PHP Fatal error: Declaration of Foxy\Json\JsonFile::encode($data, $options = 448) must be compatible with Composer\Json\JsonFile::encode($data, int $options = 448, string $indent = self::INDENT_DEFAULT): string in vendor/foxy/foxy/Json/JsonFile.php on line 98
|
Same problem here. Thank you for the update. |
|
Is there an idea when this will be merged? |
|
Thank you for your feedbacks. Unfortunately, this Pull Request goes way too far beyond the scope of the topic, namely, making it compatible with Composer 2.5 and above. I'm not going to go into details, but as it stands, all of the proposed changes mainly concern the style of code and CI using Github Actions whereas the project is tested with Travis CI. In addition, this PR does not respect the project's PHP CS Fixer configurations. In the event that this PR is simplified to what it describes or another PR does this, I would voluntarily merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error:
This will also bump the minimum for php to
^7.3, but come on. just let php 5.x die!Maybe this should be a PR to a new branch called 2.0 or something?
I'll be adding to this PR, so I prefixed it with DRAFT.