This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
[Microservice] Node Manager - Metadata Management #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xieus
changed the title
|
Please address comments in the linked PR (#185) |
xieus
reviewed
May 12, 2020
services/node_manager/src/main/java/com/futurewei/alcor/nodemanager/dao/NodeRepository.java
Outdated
Show resolved
Hide resolved
services/node_manager/src/main/java/com/futurewei/alcor/nodemanager/entity/NodeInfo.java
Outdated
Show resolved
Hide resolved
xieus
reviewed
May 12, 2020
...ode_manager/src/test/java/com/futurewei/alcor/nodemanager/controller/NodeControllerTest.java
Show resolved
Hide resolved
xieus
reviewed
May 12, 2020
...manager/src/main/java/com/futurewei/alcor/nodemanager/service/implement/NodeServiceImpl.java
Show resolved
Hide resolved
xieus
reviewed
May 12, 2020
services/node_manager/src/main/java/com/futurewei/alcor/nodemanager/entity/NodeInfo.java
Outdated
Show resolved
Hide resolved
xieus
reviewed
May 12, 2020
services/node_manager/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
xieus
reviewed
May 13, 2020
...es/node_manager/src/main/java/com/futurewei/alcor/nodemanager/controller/NodeController.java
Show resolved
Hide resolved
services/node_manager/src/main/java/com/futurewei/alcor/nodemanager/dao/NodeRepository.java
Show resolved
Hide resolved
..._manager/src/main/java/com/futurewei/alcor/nodemanager/service/implement/NodeFileLoader.java
Outdated
Show resolved
Hide resolved
services/node_manager/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...ode_manager/src/test/java/com/futurewei/alcor/nodemanager/controller/NodeControllerTest.java
Show resolved
Hide resolved
xieus
approved these changes
May 13, 2020
..._manager/src/main/java/com/futurewei/alcor/nodemanager/service/implement/NodeFileLoader.java
Outdated
Show resolved
Hide resolved
xieus
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node Manager (Part I) manages host/node metadata such as id, name, ip address, MAC address, veth, etc. . Here is the brief description of node manager:
NOTE: Link to PR (#185) for comment tracking.