Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gost/windows): ignore other products that do not have KBs #2054

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix(gost/windows): ignore other products that do not have KBs #2054

merged 1 commit into from
Oct 23, 2024

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented Oct 23, 2024 •
edited
Loading

What did you implement:

ignore other products that do not have KBs

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

by unit test

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Oct 23, 2024
@MaineK00n MaineK00n changed the title fix(gost/windows): support for other products that do not have a KB fix(gost/windows): ignore other products that do not have KBs Oct 23, 2024
@MaineK00n MaineK00n requested a review from shino October 23, 2024 02:49
shino
shino approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@shino shino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪛

@MaineK00n MaineK00n merged commit 236fa2a into master Oct 23, 2024
7 checks passed
@MaineK00n MaineK00n deleted the MaineK00n/patch-1 branch October 23, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shino shino shino approved these changes

Assignees

@MaineK00n MaineK00n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaineK00n @shino