CANCELING.onCanceled() never triggered when being stopped before connecting #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the case when
TcpTransport.stop()
is called just after aTcpTransport.start()
call. There is a chance that thesocketState
becomesCANCELING
which is changed by theTcpTransport.stop()
call. The following logic would prevent it from connecting and doing any further initialization. In this scenario, theCANCELING.onCanceled()
would never be triggered after that, which means theonCompleted
Task of theTcpTransport.stop()
parameter would never be triggered as well. As a result, the client will wait forever if it relies on theonCompleted
Task to be called to proceed.