Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix marshmallow partial loading should skip JSON schema required fields #113

Closed
wants to merge 1 commit into from
Closed

Fix marshmallow partial loading should skip JSON schema required fields #113

wants to merge 1 commit into from

Conversation

lehainam-dev
Copy link

Resolve #112.

@lehainam-dev lehainam-dev mentioned this pull request May 19, 2020
Open
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.3%) to 95.708% when pulling 6a47e06 on lehainam-dev:master into 3f62e63 on fuhrysteve:master.

@lehainam-dev
Copy link
Author

I think I had enough tests to cover all addition lines in the PR.
As I see in other PR, people said that there is issue with calculate coverage. So I leave the PR back to you @fuhrysteve.

Have a nice day.

@kaos
Copy link
Contributor

kaos commented Mar 30, 2021

@fuhrysteve any reason this PR was not merged?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dump partial loading schema still return required fields.
3 participants
@lehainam-dev @coveralls @kaos