Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mint060sp (motorola 060isp/fpsp) #335

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

agranlund
Copy link
Contributor

The Motorola 060 support package emulates the missing Integer as well as Fpu instructions, thus:

  • Removed complaints when using on LC/EC and have it install the integer part.
  • Renamed the executable from fpu060sp -> 060sp for the same reason.

In addition:

  • Fixed broken 68060 detection.
  • Fixed a couple of callout functions.

Should this executable be built and distributed with the 060 Freemint builds?
CT60 TOS has the 060 isp/fpsp built in already but for other hardware running EmuTos this is handy.

Preferably, this should come with EmuTOS builds rather than Freemint since it's equally useful when running EmuTOS only.

Fixed broken 68060 detection
Fixed a couple of callouts
No longer complains on LC/EC
Renamed program to 060sp.prg
@th-otto
Copy link
Contributor

th-otto commented Apr 18, 2024

* Removed complaints when using on LC/EC and have it install the integer part.

I don't think this is the correct thing to do. The fpsp only emulates the instructions that were removed from 060 (like fsin etc), but not the ones that are still there. To support 060 without FPU, you would have to emulate much more.

@mikrosk
Copy link
Member

mikrosk commented Apr 18, 2024

Are you sure @th-otto that you have interpreted this patch correctly? My understanding is that on LC/EC (no FPU) the FPSP wouldn't install at all, therefore omitting the important stuff as emulation of missing integer instruction which causes crash for some apps.

This patches enables emulation of integer instructions and keeps the rest as it was, i.e. it's clearly an improvement over the previous state (where both integer and FPU instructions were causing crashes).

Should this executable be built and distributed with the 060 Freemint builds?

I think it should be built into the kernel but see below.

Preferably, this should come with EmuTOS builds rather than Freemint since it's equally useful when running EmuTOS only.

I tend to agree, it should not even "come with" but be "built in" EmuTOS, same as the PMMU initialisation for 040+.

But as a temporary workaround, if this patch gets merged, I have nothing against adding it to our 060 builds.

@agranlund
Copy link
Contributor Author

The fpsp only emulates the instructions that were removed from 060 (like fsin etc)

Yep but the isp part of that package is valid for EC/LC to prevent programs from crashing on the missing Integer instructions.

@mikrosk mikrosk merged commit 3a4363c into freemint:master Jun 10, 2024
11 checks passed
@mikrosk
Copy link
Member

mikrosk commented Jun 10, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants