Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subset of CAP court names #17

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

4ndygu
Copy link

@4ndygu 4ndygu commented Jul 6, 2021

Hi there! I am currently mining some of the data in the Caselaw Access Project API, and we noticed that some of the Regex patterns in courts.json do not match the courts displayed in api.case.law/v1/courts/. This pull requests takes a subset of the most frequently seen courts in CAP and adds those court names to the Regex pattern of the underlying dataset.

@4ndygu
Copy link
Author

4ndygu commented Jul 6, 2021

Also tagging @jcushman for visibility.

@mlissner
Copy link
Member

mlissner commented Jul 6, 2021

Thanks @4ndygu!

This looks OK to me at a skim, though tests seem to be failing.

@flooie will you give it a final review once tests are working?

@mlissner mlissner requested a review from flooie July 6, 2021 22:42
@4ndygu
Copy link
Author

4ndygu commented Jul 11, 2021

Hi @mlissner! sorry for the late response, and my bad -- it seems like I may have included some of the regex patterns in the examples page, which polluted the tests. These should be updated now!

@mlissner
Copy link
Member

This should be back to you, then, @flooie.

@flooie
Copy link
Collaborator

flooie commented Jul 12, 2021

@4ndygu this looks great. Thank you for adding your two cents. I hope to give this a deeper look tomorrow.

@flooie
Copy link
Collaborator

flooie commented Jul 12, 2021

@mlissner also if I remember correctly, we haven't completed regex patterns for every example permutation yet, so I don't think @4ndygu additions caused that test to fail.

@4ndygu
Copy link
Author

4ndygu commented Jul 12, 2021

Hi @flooie! Just to clarify, might be my bad here -- i think the error arose because I accidentally added two patterns to the examples section as opposed to regex, which would have caused the existing regex patterns at the time to fail.

@flooie
Copy link
Collaborator

flooie commented Jul 12, 2021 via email

@CLAassistant
Copy link

CLAassistant commented Dec 18, 2021

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants