-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch installation errors and display them. #952
Conversation
d2fd81c
to
585f6f3
Compare
On MacOS, the tests are currently failing. I managed to reproduce on our mac mini. For a reason I still need to understand, the following command hangs indefinitely. usr/local/bin/docker image list --format "{{.ID}}" dangerzone.rocks/dangerzone And as a result the GUI continues showing that it's "installing" the image. |
Tests are now passing (without doing any changes). I'm not sure if it was due to an error with the runners? 🤔 @apyrgio I believe this is ready for review. |
Tested the PR on a Windows environment. Aside from a stray exception, everything else seems to work nicely. Nice job! |
Not much else to comment on, I think it's good to merge. |
345fba5
to
2ca6a02
Compare
Tests were intermittently failing on MacOS and Windows, due to the way we tested threads, which was a bit brittle. I changed the approach to flatten threads during the tests (replacing If that's okay for you @apyrgio, and that tests are green on all targets, I'll wait until #748 is merged, rebase and we should be good. |
4caad39
to
8ef0a76
Compare
8ef0a76
to
a95b612
Compare
This catches the errors that can happen during installation, and during some other phases, and display them to the end user in the interface.
Fixes #193