Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github issue templates #939

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Use github issue templates #939

merged 1 commit into from
Oct 10, 2024

Conversation

almet
Copy link
Contributor

@almet almet commented Oct 3, 2024

This adds two issue templates, one as a form and the other as some text already filled in.

Here is what it looks like:

image

Bug report:

image


Feature request:

image


Is there any other input that could be valuable here?

Note that we could also have a specific template for "Conversion failed" issues, where we could add some more specific information about the docker / podman setup, and ask the user to run specific tasks (like add SC_DEBUG to the docker run command line to get more logs back).

I am curious what you think on this, and if you think it could be valuable? 🤔

Edit: I realize that these screencaps are not up to date. If you want to have a look at what it looks like now for the form, look at this link instead

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
@almet
Copy link
Contributor Author

almet commented Oct 7, 2024

I've updated according to our latest discussions. It's possible to try it out with this link:

https://github.com/almet/dangerzone/issues/new/choose

It's worth noting that this currently on a new potential dangerzone-cli --debug flag to simplify the process for end users, as implemented in #941.

.github/ISSUE_TEMPLATE/bug_report_linux.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report_macos.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report_windows.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report_linux.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report_linux.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report_macos.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report_macos.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report_macos.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report_macos.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report_macos.yml Outdated Show resolved Hide resolved
@almet
Copy link
Contributor Author

almet commented Oct 9, 2024

I've updated the PR with your comments in 8191e0b. Thanks!

@almet almet force-pushed the 920-gh-issue-templates branch from c4cea33 to 8191e0b Compare October 9, 2024 15:18
@apyrgio
Copy link
Contributor

apyrgio commented Oct 9, 2024

Looks great. I've noticed a few more things (e.g., that the dropdown list for the macOS chip still shows None), but they are cosmetic at this point, and we can iron them later. I believe you can merge.

@almet almet force-pushed the 920-gh-issue-templates branch from 8191e0b to 56ad1f6 Compare October 10, 2024 07:36
@almet
Copy link
Contributor Author

almet commented Oct 10, 2024

Marking the dropdown field as mandatory made the blank option disappear. Will merge once the CI is green.

@almet almet force-pushed the 920-gh-issue-templates branch from 56ad1f6 to ee991ca Compare October 10, 2024 07:57
@almet almet merged commit ee991ca into main Oct 10, 2024
43 of 44 checks passed
@almet almet deleted the 920-gh-issue-templates branch October 10, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants