Update Drupal UrlScraper #1790
Open
Update Drupal UrlScraper #1790
+95
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm trying to test locally, and I'm getting the error below--before my changes and after them. Can anyone help me debug it? |
|
It seems that the structure of the Drupal docs has been changed. Please revise item 4 from https://github.com/freeCodeCamp/devdocs/blob/main/docs/adding-docs.md The following patch allowed me to scrape v7 docs: diff --git a/lib/docs/filters/drupal/entries.rb b/lib/docs/filters/drupal/entries.rb
index 9da70441..b0c99d91 100644
--- a/lib/docs/filters/drupal/entries.rb
+++ b/lib/docs/filters/drupal/entries.rb
@@ -20,7 +20,7 @@ module Docs
elsif subpath =~ /core!themes/
'themes'
else
- css('.breadcrumb > a')[1].content
+ css('.breadcrumb a')[1].content
end
end
diff --git a/lib/docs/scrapers/drupal.rb b/lib/docs/scrapers/drupal.rb
index 3798caec..96cca5e9 100644
--- a/lib/docs/scrapers/drupal.rb
+++ b/lib/docs/scrapers/drupal.rb
@@ -10,7 +10,7 @@ module Docs
html_filters.push 'drupal/entries', 'drupal/clean_html', 'title'
options[:decode_and_clean_paths] = true
- options[:container] = '#page-inner'
+ options[:container] = '#page'
options[:title] = false
options[:root_title] = 'Drupal' |
|
Thank you, @simon04, I've applied your patch. I still get the same runtime error, though, running |
|
I'm going to go out on a limb and mark this ready for review, unanswered question notwithstanding. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Drupal 7 and 8 and adds Drupal 9 and 10.
about_tmpl.coffeematches its data inself.attributionSOURCEfile inpublic/icons/your_scraper_name/are up-to-date if the documentation has a custom iconself.linkscontains up-to-date urls ifself.linksis defined