Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

fix(challenges): improved tests for adding background/background-image #325

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jonathan-grah
Copy link
Member

Using the background-image property instead of background should still pass the tests.

image

@jonathan-grah jonathan-grah force-pushed the fix/background-image-tests branch from 28864a4 to a59f601 Compare September 26, 2018 22:48
@jonathan-grah jonathan-grah force-pushed the fix/background-image-tests branch from a59f601 to 343acc6 Compare September 26, 2018 22:54
@RandellDawson
Copy link
Member

RandellDawson commented Sep 27, 2018

So are you suggesting the challenge instructions should be updated to explain how to use both background and background-image properties? Maybe the instructions can be changed to reflect how both can be used to change the background image, where background-image can only specify the image and the the background property can specify other properties ( ) in the same line. If there are not already other challenges dealing with the other property value which it can set, the I think there would need to be an additional challenge added to deal with them.

Maybe instead of this lesson teaching about the background property and only specifying the image, the lesson should be about the background-image property and the tests should only pass if background-image property is used. I think this lesson could lead into a next lesson where the background property is discussed in more detail.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants