Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): use percentages for content row container height #1281

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

a2937
Copy link
Member

@a2937 a2937 commented Jan 13, 2025

Summary of changes

This makes the height of the row container grow and shrink relative to the screen height rather than use fixed height when zoomed in. I also updated some of the units to be rem instead of px.

Checklist

  • I have read and followed the contribution guidelines.
  • I have read through the Code of Conduct and agree to abide by the rules.
  • This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
  • My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
  • I have provided a summary of my changes.

closes #1280

@shootermv
Copy link
Contributor

@a2937 looks very nice!
question: have you tested the change on ubuntu operated machine?

@a2937
Copy link
Member Author

a2937 commented Jan 15, 2025

The closest I have to Ubuntu is Windows Subsystem For Linux. I did not open up Firefox from it to test this PR yet though.

@shootermv
Copy link
Contributor

shootermv commented Jan 15, 2025

May be better to ask @danielfriere-dev to take a look...

@jdwilkin4 jdwilkin4 merged commit f8248c5 into freeCodeCamp:main Jan 23, 2025
4 checks passed
@a2937 a2937 deleted the fix(ui)/zoom-less-move branch January 23, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] - Overlapping image
3 participants