Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option allow_errors. #257

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Conversation

tpapp
Copy link
Contributor

@tpapp tpapp commented Oct 14, 2024

Fixes #201.

@tpapp
Copy link
Contributor Author

tpapp commented Oct 14, 2024

I think the docs CI failure is unrelated, I can fix the manifest if needed though.

@fredrikekre
Copy link
Owner

Thanks, I haven't reviewed it but perhaps continue_on_error would be more descriptive? Because that is what will happen, right?

@tpapp
Copy link
Contributor Author

tpapp commented Oct 15, 2024

Thanks, I renamed the argument.

Another open question is how to show that error: currently it just falls back to show, we could use showerror, and maybe precede that with an ERROR: as that is more familiar to users.

Please review when you have the time, this is a minor change but would make it much easier for me to write a tutorial I am working on.

@fredrikekre fredrikekre merged commit 28a4126 into fredrikekre:master Oct 16, 2024
8 checks passed
@fredrikekre
Copy link
Owner

fredrikekre commented Oct 16, 2024

Thanks, I added a changelog entry. I have another feature in the pipeline that I will finish and then release this with version 2.20.

Edit: JuliaRegistries/General#117389

tpapp added a commit to tpapp/Literate.jl that referenced this pull request Oct 16, 2024
Follow up to fredrikekre#257, uses showerror and the output channel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to capture errors?
2 participants